-
Notifications
You must be signed in to change notification settings - Fork 5.9k
[API Compatibility No.372] add param decorator for paddle.randint -part #77194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
你的PR提交成功,感谢你对开源项目的贡献! |
python/paddle/tensor/ops.py
Outdated
| if out is not None: | ||
| import paddle | ||
|
|
||
| paddle.assign(res, out) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个为何不采用下沉的方式
python/paddle/tensor/stat.py
Outdated
| x, axis=axis, unbiased=unbiased, keepdim=keepdim, name=name, out=out | ||
| ) | ||
| if out is not None: | ||
| out.sqrt_() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
用paddle.sqrt(out=) 吧,另外var如果支持了别名,这里是不是透传就行。无需再来一次装饰器。
|
square已经下沉了,重新处理std、randint吧 |
1080822 to
4bd5672
Compare
c114028 to
4a0bbfb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #77194 +/- ##
===========================================
Coverage ? 100.00%
===========================================
Files ? 1
Lines ? 3
Branches ? 0
===========================================
Hits ? 3
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/re-run all-failed |
python/paddle/tensor/stat.py
Outdated
| return result | ||
|
|
||
|
|
||
| @ParamAliasDecorator( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
std这个不用改,其他PR已经修改了,需要复用var的装饰器逻辑。
python/setup.py.in
Outdated
| for command in commands: | ||
| if os.system(command) != 0: | ||
| raise Exception("patch ${FLUID_CORE_NAME}.%s failed, command: %s" % (ext_name, command)) | ||
| if sys.platform == 'darwin': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里需要修改的原因是?是修了一个额外的bug吗,可以在PR描述里具体描述下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里需要修改的原因是?是修了一个额外的bug吗,可以在PR描述里具体描述下
这个修改要不重新启一个PR吧,这个和API兼容性:randint有关系吗
… ApiEnhance352_372_376
… ApiEnhance352_372_376
4b92cef to
aae4504
Compare
Remove macOS specific subprocess handling for command execution.
Removed TestSquareAPI class and its test method for paddle.square.
Removed TestStdAliasAndOut class and its tests for paddle.std.
…PaddleDebug into ApiEnhance352_372_376
|
/re-run all-failed |
PR Category
User Experience
PR Types
New features
Description
add param decorator and unit tests for paddle.randint