Skip to content

Conversation

@Manfredss
Copy link
Contributor

@Manfredss Manfredss commented Jan 5, 2026

PR Category

User Experience

PR Types

New features

Description

add param decorator and unit tests for paddle.randint

@paddle-bot
Copy link

paddle-bot bot commented Jan 5, 2026

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

if out is not None:
import paddle

paddle.assign(res, out)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个为何不采用下沉的方式

x, axis=axis, unbiased=unbiased, keepdim=keepdim, name=name, out=out
)
if out is not None:
out.sqrt_()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用paddle.sqrt(out=) 吧,另外var如果支持了别名,这里是不是透传就行。无需再来一次装饰器。

@zhwesky2010
Copy link
Contributor

square已经下沉了,重新处理std、randint吧

@Manfredss Manfredss force-pushed the ApiEnhance352_372_376 branch from 1080822 to 4bd5672 Compare January 8, 2026 14:29
@Manfredss Manfredss force-pushed the ApiEnhance352_372_376 branch from c114028 to 4a0bbfb Compare January 10, 2026 09:51
@Manfredss Manfredss changed the title [API Compatibility No.352、372、376] add param decorator for paddle.std, paddle.square and paddle.randint -part [API Compatibility No.352、372] add param decorator for paddle.std and paddle.randint -part Jan 10, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@a59e49d). Learn more about missing BASE report.

Additional details and impacted files
@@             Coverage Diff             @@
##             develop    #77194   +/-   ##
===========================================
  Coverage           ?   100.00%           
===========================================
  Files              ?         1           
  Lines              ?         3           
  Branches           ?         0           
===========================================
  Hits               ?         3           
  Misses             ?         0           
  Partials           ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Manfredss
Copy link
Contributor Author

/re-run all-failed

@zhwesky2010 zhwesky2010 changed the title [API Compatibility No.352、372] add param decorator for paddle.std and paddle.randint -part [API Compatibility No.352、372] add param decorator for paddle.randint -part Jan 13, 2026
return result


@ParamAliasDecorator(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

std这个不用改,其他PR已经修改了,需要复用var的装饰器逻辑。

for command in commands:
if os.system(command) != 0:
raise Exception("patch ${FLUID_CORE_NAME}.%s failed, command: %s" % (ext_name, command))
if sys.platform == 'darwin':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里需要修改的原因是?是修了一个额外的bug吗,可以在PR描述里具体描述下

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里需要修改的原因是?是修了一个额外的bug吗,可以在PR描述里具体描述下

这个修改要不重新启一个PR吧,这个和API兼容性:randint有关系吗

@Manfredss Manfredss changed the title [API Compatibility No.352、372] add param decorator for paddle.randint -part [API Compatibility No.372] add param decorator for paddle.randint -part Jan 13, 2026
@Manfredss Manfredss force-pushed the ApiEnhance352_372_376 branch from 4b92cef to aae4504 Compare January 16, 2026 08:19
Manfredss and others added 5 commits January 16, 2026 16:20
Remove macOS specific subprocess handling for command execution.
Removed TestSquareAPI class and its test method for paddle.square.
Removed TestStdAliasAndOut class and its tests for paddle.std.
@Manfredss
Copy link
Contributor Author

/re-run all-failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants